Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for creating secrets using certmanager #133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nierhoff
Copy link
Contributor

Hi,

A PR, which is a proposal that might require a bit of discussion and corrections.

I suggest to support that cert-manager create the secrets for deploy.ssl.endpointSecretName and transportSecretName.

A configuation could look like this

deploy:
  ssl:
    endpointSecretName: "test-certificate"
    transportSecretName: ""
    certmanager:
      enabled: true
      endpoint:
        enabled: true
        commonName: 'example-infinispan'
      transport:
        enabled: false

This will create the secret "test-certificate" by use of cert-manager, this example will not create a secret for transport.

@Nierhoff
Copy link
Contributor Author

Du you have any feedback on this PR ?

Copy link
Collaborator

@rigazilla rigazilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a user POV I like this feature, from the design POV I guess the point is that it introduces dependencies with external component and we may not want to add this kind of complexity.

If we decide to add this feature, I would like to have only the enabled flags in the values.yaml, something like:

  • commonName be computed in certificate.yaml
  • all the remaining values set to default in certificate.yaml

this to keep values.yaml clean from external spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants