Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write extra_files when building pyembed artifacts v2 #499

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mxk
Copy link

@mxk mxk commented Jan 20, 2022

These are the changes I needed in order to enable the workflow described in #498 when packaging filesystem-relative files via run-build-script:

  1. Write the artifacts directly to OUT_DIR and skip copying them from the build/ directory.
  2. Write extra_files to a zstd-compressed tar archive.

Using an archive rather than materializing extra files directly is an improvement on #466, which makes the process faster and simplifies moving the files to their final destination. It also enables the use case where the archive is compiled into the final binary via include_bytes! and then extracted at runtime to always be in the right place. This allows the entire application to still be distributed as a single binary.

I'm intentionally not calling write_extra_files from write_files because the archive is only needed as the output of run-build-script.

@indygreg indygreg force-pushed the main branch 2 times, most recently from 5e0524b to 789c62e Compare May 31, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant