.github/workflows/workspace.yml #700
Annotations
3 errors and 5 warnings
Run actions-rs/clippy@master:
python-packaging/src/licensing.rs#L115
error: incorrect implementation of `partial_cmp` on an `Ord` type
--> python-packaging/src/licensing.rs:115:1
|
115 | / impl PartialOrd for ComponentFlavor {
116 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
| | _____________________________________________________________-
117 | || match (self.python_module_name(), other.python_module_name()) {
118 | || (Some(a), Some(b)) => a.partial_cmp(b),
119 | || _ => {
... ||
125 | || }
126 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
127 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type
= note: `#[deny(clippy::incorrect_partial_ord_impl_on_ord_type)]` on by default
|
Run actions-rs/clippy@master:
python-packaging/src/licensing.rs#L225
error: incorrect implementation of `partial_cmp` on an `Ord` type
--> python-packaging/src/licensing.rs:225:1
|
225 | / impl PartialOrd for LicensedComponent {
226 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
| | _____________________________________________________________-
227 | || self.flavor.partial_cmp(&other.flavor)
228 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
229 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type
|
Run actions-rs/clippy@master:
python-packaging/src/licensing.rs#L979
error: incorrect implementation of `partial_cmp` on an `Ord` type
--> python-packaging/src/licensing.rs:979:1
|
979 | / impl PartialOrd for PackageLicenseInfo {
980 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
| | _____________________________________________________________-
981 | || if self.package == other.package {
982 | || self.version.partial_cmp(&other.version)
983 | || } else {
984 | || self.package.partial_cmp(&other.package)
985 | || }
986 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
987 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy@master. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Run actions-rs/clippy@master:
python-packed-resources/src/parser.rs#L65
warning: variable does not need to be mutable
--> python-packed-resources/src/parser.rs:65:13
|
65 | let mut state = self.blob_sections[resource_field as usize]
| ----^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
Run actions-rs/clippy@master:
python-packed-resources/src/parser.rs#L516
warning: the following explicit lifetimes could be elided: 'a
--> python-packed-resources/src/parser.rs:516:23
|
516 | pub fn load_resources<'a>(data: &'a [u8]) -> Result<ResourceParserIterator<'a>, &'static str> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
516 - pub fn load_resources<'a>(data: &'a [u8]) -> Result<ResourceParserIterator<'a>, &'static str> {
516 + pub fn load_resources(data: &[u8]) -> Result<ResourceParserIterator<'_>, &'static str> {
|
|
Run actions-rs/clippy@master:
python-packed-resources/src/parser.rs#L530
warning: the following explicit lifetimes could be elided: 'a
--> python-packed-resources/src/parser.rs:530:22
|
530 | fn load_resources_v3<'a>(data: &'a [u8]) -> Result<ResourceParserIterator<'a>, &'static str> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
530 - fn load_resources_v3<'a>(data: &'a [u8]) -> Result<ResourceParserIterator<'a>, &'static str> {
530 + fn load_resources_v3(data: &[u8]) -> Result<ResourceParserIterator<'_>, &'static str> {
|
|
Run actions-rs/clippy@master:
python-packaging/src/interpreter.rs#L44
warning: this `impl` can be derived
--> python-packaging/src/interpreter.rs:44:1
|
44 | / impl Default for PythonInterpreterProfile {
45 | | fn default() -> Self {
46 | | PythonInterpreterProfile::Isolated
47 | | }
48 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` on by default
= help: remove the manual implementation...
help: ...and instead derive it...
|
28 + #[derive(Default)]
29 | pub enum PythonInterpreterProfile {
|
help: ...and mark the default variant
|
34 ~ #[default]
35 ~ Isolated,
|
|
The logs for this run have expired and are no longer available.
Loading