Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.4.0 final version bump #59

Merged
merged 2 commits into from
Aug 28, 2024
Merged

0.4.0 final version bump #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6fef18
IGN-10603 Late catch: mistake in .kts sdk_version
brianeray Aug 28, 2024
ccdee13
0.4.0 final version bump
brianeray Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generator/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ plugins {
}

allprojects {
project.version = "0.4.0-SNAPSHOT"
project.version = "0.4.0"
}

tasks {
Expand Down
4 changes: 2 additions & 2 deletions generator/generator-cli/src/main/kotlin/io/ia/sdk/tools/module/cli/ModuleGeneratorCli.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import java.util.concurrent.Callable

@Command(
name = "ignition-module-gen",
version = ["0.4.0-SNAPSHOT"],
version = ["0.4.0"],
description = ["Generates an Ignition module skeleton according to provided arguments."],
subcommands = [HelpCommand::class],
mixinStandardHelpOptions = true
Expand Down Expand Up @@ -160,7 +160,7 @@ class ModuleGeneratorCli : Callable<Int> {
configBuilder.debugPluginConfig(true)
configBuilder.rootPluginConfig("""id("io.ia.sdk.modl")""")
} else {
configBuilder.rootPluginConfig("""id("io.ia.sdk.modl") version("0.4.0-SNAPSHOT")""")
configBuilder.rootPluginConfig("""id("io.ia.sdk.modl") version("0.4.0")""")
}

val config = configBuilder.build()
Expand Down
2 changes: 1 addition & 1 deletion ...tor/generator-core/src/main/kotlin/io/ia/ignition/module/generator/api/GeneratorConfig.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ data class GeneratorConfig constructor(
* generated, as it is assumed the plugin will be established via 'includeBuild' in settings.gradle
* pluginManagement.
*/
val modulePluginVersion: String = "0.4.0-SNAPSHOT",
val modulePluginVersion: String = "0.4.0",

/**
* If signing the module should be required, set to false. Set to true by default to allow building the
Expand Down
2 changes: 1 addition & 1 deletion ...erator-core/src/main/kotlin/io/ia/ignition/module/generator/api/GeneratorConfigBuilder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class GeneratorConfigBuilder {
private var debugPluginConfig: Boolean = false
private var rootPluginConfig: String = ""
private var useRootForSingleProjectScope: Boolean = false
private var modulePluginVersion: String = "0.4.0-SNAPSHOT"
private var modulePluginVersion: String = "0.4.0"
private var allowUnsignedModules: Boolean = false

// builder methods
Expand Down
2 changes: 1 addition & 1 deletion generator/generator-core/src/main/resources/templates/config/modlPluginConfig.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ ignitionModule {
* the course of a major Ignition (7.9, 8.0, etc) version, except for when the Ignition Platform adds/changes APIs
* used by the module.
*/
requiredIgnitionVersion.set(rootProject.ext.sdk_version)
requiredIgnitionVersion.set(sdk_version)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should never have patched this template in #40. There was only a problem with the modlPluginConfig.groovy template, not this Kotlin DSL template.

/*
* This is a map of String: String, where the 'key' represents the fully qualified path to the project
* (using gradle path syntax), and the value is the shorthand Scope string.
Expand Down
4 changes: 2 additions & 2 deletions gradle-module-plugin/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ For current versions of gradle, simply add to your `build.gradle.kts`:
```kotlin
// build.gradle.kts
plugins {
id("io.ia.sdk.modl") version("0.4.0-SNAPSHOT")
id("io.ia.sdk.modl") version("0.4.0")
}
```

Expand All @@ -28,7 +28,7 @@ Or for Groovy DSL buildscripts:
```groovy
// build.gradle
plugins {
id 'io.ia.sdk.modl' version '0.4.0-SNAPSHOT'
id 'io.ia.sdk.modl' version '0.4.0'
}
```

Expand Down
2 changes: 1 addition & 1 deletion gradle-module-plugin/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ repositories {
}

group = "io.ia.sdk"
version = "0.4.0-SNAPSHOT"
version = "0.4.0"

configurations {
val functionalTestImplementation by registering {
Expand Down
Loading