Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support lazy evaluation of signed module output file #55

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Support lazy evaluation of signed module output file #55

merged 1 commit into from
Aug 13, 2024

Conversation

benmusson
Copy link
Contributor

This change converts .map/.get to .flatMap to allow for lazier evaluation of the signed module output file.

Redo of PR #51 with clean history.

@benmusson benmusson mentioned this pull request Aug 13, 2024
Closed
@brianeray brianeray self-requested a review August 13, 2024 21:23
@brianeray
Copy link
Collaborator

From the original #51 , my estimation

I think this is implicitly tested by existing coverage in SignModuleTest, but need to loop back around on Monday to be sure.

was correct. Existing tests cover this patch already.

@brianeray brianeray merged commit f8e32d3 into inductiveautomation:master Aug 13, 2024
1 check passed
@brianeray brianeray mentioned this pull request Aug 13, 2024
Closed
@benmusson benmusson deleted the fix/lazy-signed-module-output branch August 13, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianeray brianeray brianeray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benmusson @brianeray