Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate Module.xml jar entries based on scope. #53

Merged

Commits on Aug 13, 2024

  1. deduplicate module.xml jar entries by combining scopes

    add test for jar presence, duplication, and sort order
    
    linting
    benmusson committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    54b121e View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Configuration menu
    Copy the full SHA
    44ee58a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    06930b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Configuration menu
    Copy the full SHA
    6539bdb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    738a9f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Configuration menu
    Copy the full SHA
    7b8a8f8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e7489c9 View commit details
    Browse the repository at this point in the history
  3. combine scope, then create pair

    benmusson authored and brianeray committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    376f0a2 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. IGN-10612 feedback from IA module devs

    Add `--foldJars` task option to preserve the old behavior by default,
    it's a breaking change and maybe the dups are useful to some.
    
    The option if passed does the scope folding and the sorting as before
    and another sort of folding for `CDG`-scoped jars, turning them into
    the `A`[ll]-scoped equivalent.
    
    Plus noticed that the tests fall into the `assertEquals` API trap where
    you think the argument order is `actual, expected` but it's really
    `expected, actual`. Completely nonintuitive and sort of asymmetric to
    other `assert*` APIs but when `assertEquals` fails having them in the
    wrong order makes things harder to troubleshoot.
    brianeray committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    22946e2 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Configuration menu
    Copy the full SHA
    b738b38 View commit details
    Browse the repository at this point in the history