-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-duplicate Module.xml jar entries based on scope. #53
Merged
brianeray
merged 10 commits into
inductiveautomation:master
from
benmusson:fix/module-xml-jar-deduplication
Aug 26, 2024
Merged
De-duplicate Module.xml jar entries based on scope. #53
brianeray
merged 10 commits into
inductiveautomation:master
from
benmusson:fix/module-xml-jar-deduplication
Aug 26, 2024
Commits on Aug 13, 2024
-
deduplicate module.xml jar entries by combining scopes
add test for jar presence, duplication, and sort order linting
Configuration menu - View commit details
-
Copy full SHA for 54b121e - Browse repository at this point
Copy the full SHA 54b121eView commit details
Commits on Aug 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 44ee58a - Browse repository at this point
Copy the full SHA 44ee58aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06930b7 - Browse repository at this point
Copy the full SHA 06930b7View commit details
Commits on Aug 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6539bdb - Browse repository at this point
Copy the full SHA 6539bdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 738a9f5 - Browse repository at this point
Copy the full SHA 738a9f5View commit details
Commits on Aug 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7b8a8f8 - Browse repository at this point
Copy the full SHA 7b8a8f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7489c9 - Browse repository at this point
Copy the full SHA e7489c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 376f0a2 - Browse repository at this point
Copy the full SHA 376f0a2View commit details
Commits on Aug 20, 2024
-
IGN-10612 feedback from IA module devs
Add `--foldJars` task option to preserve the old behavior by default, it's a breaking change and maybe the dups are useful to some. The option if passed does the scope folding and the sorting as before and another sort of folding for `CDG`-scoped jars, turning them into the `A`[ll]-scoped equivalent. Plus noticed that the tests fall into the `assertEquals` API trap where you think the argument order is `actual, expected` but it's really `expected, actual`. Completely nonintuitive and sort of asymmetric to other `assert*` APIs but when `assertEquals` fails having them in the wrong order makes things harder to troubleshoot.
Configuration menu - View commit details
-
Copy full SHA for 22946e2 - Browse repository at this point
Copy the full SHA 22946e2View commit details
Commits on Aug 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b738b38 - Browse repository at this point
Copy the full SHA b738b38View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.