Updated sumpy and boxtree to arraycontext branches #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 6, 2022
alexfikl
force-pushed
the
towards-array-context
branch
2 times, most recently
from
6668ccc
to
6737ff8
Compare
alexfikl
force-pushed
the
towards-array-context
branch
from
11ffc4c
to
6c04ef6
Compare
alexfikl
force-pushed
the
towards-array-context
branch
from
f03b5c1
to
1bd1705
Compare
alexfikl
force-pushed
the
towards-array-context
branch
from
1bd1705
to
e36f229
Compare
alexfikl
force-pushed
the
towards-array-context
branch
from
e36f229
to
c74c448
Compare
alexfikl
force-pushed
the
towards-array-context
branch
from
c74c448
to
c14cef3
Compare
alexfikl
force-pushed
the
towards-array-context
branch
from
c14cef3
to
34176c8
Compare
alexfikl
commented
Dec 19, 2022
Comment on lines
+25
to
+22
| nitpick_ignore_regex = [ | ||
| ["py:class", r"boxtree\.array_context\.(.+)"], | ||
| ] |
There was a problem hiding this comment.
Need to remove this once the boxtree changes go in.
alexfikl
commented
Dec 19, 2022
|
|
||
| # {{{ PyOpenCLArrayContext | ||
|
|
||
| class PyOpenCLArrayContext(SumpyPyOpenCLArrayContext): |
There was a problem hiding this comment.
How should this inherit from the meshmode and the sumpy array contexts? Presumably it needs functionality from both to handle the mesh and the FMM..
alexfikl
force-pushed
the
towards-array-context
branch
from
34176c8
to
66fff9f
Compare
alexfikl
force-pushed
the
towards-array-context
branch
from
66fff9f
to
1f2644b
Compare
alexfikl
force-pushed
the
towards-array-context
branch
from
1f2644b
to
0bf3614
Compare
alexfikl
force-pushed
the
towards-array-context
branch
from
0bf3614
to
961df9e
Compare
alexfikl
force-pushed
the
towards-array-context
branch
from
961df9e
to
875f858
Compare
alexfikl
force-pushed
the
towards-array-context
branch
2 times, most recently
from
fc0541c
to
c6000b2
Compare
alexfikl
force-pushed
the
towards-array-context
branch
from
c6000b2
to
8be9b04
Compare
alexfikl
force-pushed
the
towards-array-context
branch
from
8be9b04
to
af7a6ea
Compare
alexfikl
force-pushed
the
towards-array-context
branch
from
af7a6ea
to
4c1f0ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port to array context versions of
boxtreeandsumpy.TODO: