Skip to content

Commit

Permalink
mesh: remove typing ignore for override
Browse files Browse the repository at this point in the history
  • Loading branch information
alexfikl committed Aug 6, 2024
1 parent 42875af commit 5185302
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions meshmode/mesh/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ def vertex_unit_coordinates(self) -> np.ndarray:

@classmethod
@abstractmethod
def make_group(cls, **kwargs: Any) -> MeshElementGroup:
def make_group(cls, *args: Any, **kwargs: Any) -> MeshElementGroup:
"""Instantiate a new group of class *cls*.
Unlike the constructor, this factory function performs additional
Expand Down Expand Up @@ -361,13 +361,12 @@ def vertex_unit_coordinates(self) -> np.ndarray:
return mp.unit_vertices_for_shape(self._modepy_shape).T

@classmethod
# Type ignore because I do not know how to annotate this factory
# function usage. Possible reference:
# https://github.com/python/typing/discussions/1191#discussioncomment-2796173
def make_group(cls, order: int, # type: ignore[override]
def make_group(cls,
order: int,
vertex_indices: np.ndarray | None,
nodes: np.ndarray,
*, unit_nodes: np.ndarray | None = None,
*,
unit_nodes: np.ndarray | None = None,
dim: int | None = None) -> _ModepyElementGroup:

if unit_nodes is None:
Expand Down

0 comments on commit 5185302

Please sign in to comment.