WIP: Add generate parameter - Fixes #211 #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiply
force-pushed
the
add-generate-parameter
branch
from
3b6495a
to
76960eb
Compare
|
Thank you for raising this. WRT code structure, can I suggest that you introduce a 'proper' type for the Parameters object instead of relying on Please could you also update the documentation? I would suggest that we replace the current references to |
|
How it's going? :) |
|
We ended up not using this at all, after moving 100% to golang. If anyone wants to pick it up, feel free to use my work here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I've added a relatively crude parameter parse, that allows comma separated arguments, with multiple values delimited by
+, as comma is used to distinguish between multiple parameters.Verification
I've tested it by using a modified version of the bazel rules, following the comment here: Dig-Doug/rules_typescript_proto#10 (comment)
I couldn't seem to find any cli tests, so please guide me in the right direction, if I missed them.