Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: CORE-2372: Add migration sample app to examples #2390

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

charlie-chau
Copy link

@charlie-chau charlie-chau commented Nov 13, 2024

Hi👋, please prefix this PR's title with:

  • breaking-change: if you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities.
  • feat:, fix:, refactor:, docs:, or chore:.

Summary

Added sample app for migration of assets from Immutable X to Immutable zkEVM to examples/

Detail and impact of the change

Added

Changed

Deprecated

Removed

Fixed

Security

Anything else worth calling out?

Copy link

nx-cloud bot commented Nov 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7d5bf2a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.


// setup database client
const pgClient = new Pool({
user: process.env.PG_USER || 'postgres',

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical

The hard-coded value "postgres" is used as
user name
.
@charlie-chau charlie-chau changed the title CORE-2372: Add migration sample app to examples docs: CORE-2372: Add migration sample app to examples Nov 13, 2024
@zaidarain1
Copy link
Contributor

Could you please add these examples to the workspace by adding the examples directory examples/x-to-zkevm-migration-app/** in the workspaces field in the root package.json? This will ensure that we run CI checks on these examples and guarantee their validity 😄

examples/x-to-zkevm-migration-app/backend/tsconfig.json Outdated Show resolved Hide resolved
examples/x-to-zkevm-migration-app/backend/tsconfig.json Outdated Show resolved Hide resolved
Comment on lines 1 to 12
/** @type {import('tailwindcss').Config} */
module.exports = {
content: [
'./src/pages/**/*.{js,ts,jsx,tsx,mdx}',
'./src/components/**/*.{js,ts,jsx,tsx,mdx}',
'./src/app/**/*.{js,ts,jsx,tsx,mdx}',
],
theme: {
extend: {},
},
plugins: [],
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the team is looking at using Biom3 for the examples now, Craig had recently done a pass through migrating the Tailwind setups over to Biom3.

Would you be able to migrate the frontend over to Biom3 instead since we want to eventually render the examples in the docs site, so they should be using our branding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants