[NO CHANGELOG] Upgrade biome design-tokens to 0.4.4 and react to 0.27.2 #2219
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e0b5e14. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
| <MenuItem.Label size="medium"> | ||
| {heading} | ||
| </MenuItem.Label> | ||
| <MenuItem.IntentIcon | ||
| icon={intentIcon} | ||
| icon={intentIcon as AllSingleVariantIconKeys} |
There was a problem hiding this comment.
so it kinda depends on how many icons we want to support in here. If we want to support Dual and Single icon variants properly, then we should maybe do as above and use the typeGuard: isDualVariantIcon()
… into upgrade-biome
| @@ -17,7 +17,7 @@ function Message() { | |||
| return ( | |||
| <CardStack title="Message"> | |||
| <Sticker | |||
There was a problem hiding this comment.
@glomotion should this version upgrade have any impact on the Sticker component?
Left is after this version bump, right is prior
There was a problem hiding this comment.
@haydenfowler so stickers have not changed, but Sticker.FramedIcon has. 😅 Think we just need one extra prop here. Ill fix.
There was a problem hiding this comment.
OK this commit should fix it: 819e41e
There was a problem hiding this comment.
@glomotion Same result unfortunately 😅
There was a problem hiding this comment.
@haydenfowler OK should definitely be fixed this time. Sorry for the false start. 🤪
jiyounglee
changed the title
Upgrade biome design-tokens to 0.4.4 and react to 0.27.2