Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed decimal value printing #45

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Fixed decimal value printing #45

merged 2 commits into from
Apr 25, 2024

Conversation

janbro
Copy link
Collaborator

@janbro janbro commented Apr 23, 2024

Fixes #44

Usage

Decimal values were printing incorrectly since leading zeros were stripped during logging. Now calculate the missing leading zeros and construct a decimal value string for printing purposes.

Modifies the PoC.sol file.

PR Checklist

  • Attack Template
  • Attack Example
  • Test
  • Readme Updated

Copy link
Contributor

@arbaz-immunefi arbaz-immunefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, Good for more visibility, liked the part of concat more 0.

@janbro janbro merged commit 97f6154 into main Apr 25, 2024
4 checks passed
@janbro janbro deleted the bugfix/snapshot_printer branch April 25, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leading 0s aren't printed in fractionalized part of snapshot balances
3 participants