Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary tables for all samples #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

angelovangel
Copy link

Hi Caspar, here the proposed changes in this PR:

  • add new nf process to output summy data for all samples, as usually many samples are analysed
  • add new R script for the above
  • add aro_index.tsv in data/, used to map aro accession to card id

Several points for future dev:

  • The html table output is pretty ugly now, will be prettified with e.g. DT::datatable
  • Add new test dataset with more samples
  • I noticed the GC-content and GC-skew calculations are pretty slow. There are quite fast implementations out there (also in R) that we could use to speed up
  • I prefer to work on my fork and make PRs here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant