ARCH-2088 - +semver:breaking Changes for TechHub deployments #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove deprecated inputs from the reusable finish deployment workflow - Make techhub deployment related inputs required in the finish deployment workflow - Update workflow templates to use latest reusable workflow versions (@V3) & modify inputs accordingly - Update permissions in each of the "deploy" templates now that deployment-board permissions are no longer needed
| @@ -67,6 +66,7 @@ jobs: | |||
| working-directory: '${{ env.TF_WORKING_DIR }}' | |||
|
|
|||
| steps: | |||
| # TODO: SWAT - Need a replacement for determining which release is the latest | |||
There was a problem hiding this comment.
Just a heads up, I left a TODO here because I think it's kind of an involved fix. I looked at the way IFP did it and it seems like this could be simplified. I'd like to work on a more streamlined solution before updating this file. Maybe part of that is investigating whether this template is providing the value we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for TechHub Deployments
Changes in
im-reusable-finish-deployment-workflow.ymldeploy-notifications-channelsecrets.DEPLOY_NOTIFICATIONS_CHANNEL. This change was made because the value is not a secret, it is a variable defined at the org levelinstanceentityupdate-deployment-boardinputs.source-slotinputs.target-slotinputs.slot-swapped-with-production-slotinputs.enable-deployment-slot-trackinginputs.deployable-labelinputs.deployable-typeinputs.deployment-board-numbersecrets.DEPLOY_NOTIFICATIONS_CHANNELinputs.deploy-notifications-channelinsteadChanges in Workflow Templates
repository-projects: writeandissues: writewere removeddeployments: writewas previously added to each of these workflowsTo update to this latest version and migrate to TechHub deployments teams should follow the changes that were done to the workflow templates above.
create-github-deploymentdoes rely on a catalog-info.yml entity. If one doesn't exist, you'll need to add it for the deployments to show up in TechHub.