WE-19955 - Adding runs-on and deploy-label #239
Conversation
jsclifford
commented
Oct 27, 2023
•
jsclifford
commented
- Adding runs-on input - thus allowing teams to pick the runner and decreases load in the im-linux runner.
- Added deploy label for custom labels with updated deployment board action
|
Successfully ran branch against shopping pipeline. Works fine.
|
| runs-on: | ||
| description: 'The runner that this workflow will run on.' | ||
| required: false | ||
| type: string | ||
| default: 'im-linux' |
There was a problem hiding this comment.
I'm curious what the rationale behind this change is. I'm not opposed to it but these are all pretty straightforward tasks so running on different runners shouldn't be a necessity. The im-linux runners have recently had their max number bumped so we shouldn't be running out of those runners when these builds come up.
There was a problem hiding this comment.
...I guess what I'm asking is, do we have a different problem we need to address?
There was a problem hiding this comment.
I have seen these wait on the im-linux runner far longer than my custom runners. This change will not affect any current workflows. I was going to fork your reusable workflows to change the runners, but this is far better. I think having the option to change the runner will have better adoption. The default is still im-linux. My team and other teams would like to have the option to change the runner.
