Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix finish-build inputs #238

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix finish-build inputs #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions workflow-templates/im-build-dotnet-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Workflow Code: LoathsomeSnipe_v48 DO NOT REMOVE
# Workflow Code: LoathsomeSnipe_v49 DO NOT REMOVE
# Purpose:
# Automatically checks out the code, builds, run tests and creates artifacts
# which are uploaded to a GH release when commits are pushed to a PR. In the
Expand Down Expand Up @@ -600,10 +600,10 @@ jobs:
# 3 - Check for workflow failures
finish-build:
if: always() && needs.setup-build-workflow.outputs.CONTINUE_WORKFLOW == 'true'
needs: [dotnet-test, jest, build-deployment-artifacts]
needs: [setup-build-workfow, dotnet-test, jest]
uses: im-practices/.github/.github/workflows/im-reusable-finish-build-workflow.yml@v2
with:
next-version: ${{ needs.build-deployment-artifacts.outputs.NEXT_VERSION }}
next-version: ${{ needs.setup-build-workflow.outputs.NEXT_VERSION }}
title-of-teams-post: '<project-name> CI Build' # TODO: Replace <project-name>
is-merge-to-main: ${{ needs.setup-build-workflow.outputs.IS_MERGE_TO_MAIN }}
additional-conclusions: | # TODO: Determine if there are any additional step outcomes/outputs you want considered or remove some items if they do not apply (like jest)
Expand All @@ -620,7 +620,7 @@ jobs:
# { "name": "Workflow", "value": "${{ github.workflow }}" },
# { "name": "Run", "value": "${{ github.run_id }}" },
# { "name": "Actor", "value": "${{ github.actor }}" },
# { "name": "Version", "value": "${{ needs.build-deployment-artifacts.outputs.NEXT_VERSION }}" }
# { "name": "Version", "value": "${{ needs.setup-build-workflow.outputs.NEXT_VERSION }}" }
# ]
secrets:
MS_TEAMS_URI: ${{ vars.MS_TEAMS_URI }}