replaced line 56 of CYRKeyboardButtonView.m #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed from: if (UIInterfaceOrientationIsLandscape([UIApplication
sharedApplication].statusBarOrientation)) {
to : if ([UIScreen mainScreen].bounds.size.width > [UIScreen
mainScreen].bounds.size.height) {
iphone x issuekeyboard is crashed due to memory issue when we use CRKeyboardButton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced line 56 of CYRKeyboardButtonView.m
changed from: if (UIInterfaceOrientationIsLandscape([UIApplication sharedApplication].statusBarOrientation)) {
to : if ([UIScreen mainScreen].bounds.size.width > [UIScreen
mainScreen].bounds.size.height) {
When used in an iOS keyboard extension, the original line causes an error on compiling:
'sharedApplication' is unavailable: not available on iOS (App Extension) - Use view controller based solutions where appropriate instead.
The new line still checks if the orientation is landscape, but sharedApplication is not used and compiles with no errors.