Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic generation of CMakeLists.txt for msg packages #42

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jpbusch
Copy link
Collaborator

@jpbusch jpbusch commented Nov 5, 2024

  • automatically generate CMakeLists.txt for message packages
    • implemented in asn1ToRosMsg.py
  • only add necessary msg files to CMakeLists
  • move some access functions for dedicated msg types, to avoid unecessary dependencies

@jpbusch jpbusch requested a review from lreiher November 5, 2024 15:08
@jpbusch
Copy link
Collaborator Author

jpbusch commented Nov 7, 2024

Open questions:

  • also remove non-build msg files? Would be a 3-liner.
  • if removing the msgs, should we also remove the corresponding coding and conversion files?
  • generate the CMakeLists.txt with jinja? Disadvantage: required jinja package

@lreiher
Copy link
Member

lreiher commented Nov 7, 2024

Open questions:

  • also remove non-build msg files? Would be a 3-liner.

Yes.

  • if removing the msgs, should we also remove the corresponding coding and conversion files?

Conversion doesn't make sense if ROS messages are removed, so should be removed as well. I tend to keep coding though as the ground-truth asn1c output.

  • generate the CMakeLists.txt with jinja? Disadvantage: required jinja package

At the current point, I don't think it's necessary. Would replace the multiple f.write calls with a single multi-line text though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants