Remove assumptions about where viz params and assets live. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ory. For convenience, and due to the structure of the various datasets, I make it easier for a user to specify where the dataset is located without also having to specify the location of the visualizer params.
Default visualizer parameters to living under provided dataset directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The visualizer currently assumes that assets like in ../assets, which prevents us from running this code from anywhere but the root directory of this repo. We generalize this by adding a CLI argument with a convenient default.
Since the datasets have
visualizer_paramsfolders, we do the same and add an argument for that file.Replaces #8.