Fix for USB forwarding on Opaque Android 13 #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First, thank you for your amazing work on this project !
TL; DR : This is a fix for #526.
Change Log
The issue arose because of a specific commit on Android 13, so I reverted the commit part by part to see where the problem was coming from.
Turns out it comes from the changes made to
remoteClientLib/src/main/java/com/undatech/opaque/util/UsbDeviceManager.kt. Why? I'm honestly not sure, I searched through change logs from Android 13 to 14, but could not find anything that would explain the problem.Anyway, this change fixes the app on Android 13 while preserving the same behavior on Android 14 (I tested both). It simply
Please let me know if you would like anything changed in the PR.
Cheers !