Fix a few code smells #9198
Merged
Fix a few code smells #9198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-derevenetz
force-pushed
the
code-smell-fix
branch
from
8ac68ef
to
a88a996
Compare
ihhub
approved these changes
Oct 17, 2024
|
@oleg-derevenetz , huge thanks for these fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the remaining code smells related to the cases when non-final virtual methods are called from the constructor.
This PR also formats our Python service scripts using
blackand fixes or disables all warnings found bypylint.This PR also paraphrases a few lines from #9191.