Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue1512 #1590

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Fix issue1512 #1590

merged 4 commits into from
Oct 7, 2024

Conversation

kunmonster
Copy link
Contributor

This commit is for fixing the issue #1512 with the solution from jrobinso in #1588 , the changes are as follows.

  1. Get the configurations of all screens.
  2. Check whether user preference is null.
  3. Check whether (x, y) in user preference is within a certain screen.

fix

other behaviors

  • when the window of igv was crossing two screens in windows, the previous code will open it in the same position as last closing, this code will change it to the upper left corner of the screen containing the (x,y) of IGV
  • work normal in windows 11 with jdk21 or jdk17.

Please review the code and test it in the macos.

@jrobinso
Copy link
Contributor

jrobinso commented Oct 7, 2024

Nice. Sorry for the delay.

@jrobinso jrobinso merged commit 51ced33 into igvteam:main Oct 7, 2024
@kunmonster
Copy link
Contributor Author

Nice. Sorry for the delay.

Not matter.Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants