Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #103. Split OAS and JSON Schema. #104

Merged
merged 2 commits into from
Jan 7, 2024
Merged

Fix: #103. Split OAS and JSON Schema. #104

merged 2 commits into from
Jan 7, 2024

Conversation

ioggstream
Copy link
Collaborator

This PR

  • split JSON SCHEMA and OAS

@handrews
Copy link
Collaborator

I'll take a look. Also paging @awwright. Also could an admin of the HTTP API IETF mailing list check the approval queue for emails from me? None of my replies have been going through.

@richsalz
Copy link

richsalz commented Nov 16, 2023 via email

@jdesrosiers
Copy link
Contributor

As a reminder, we (the JSON Schema team) have decided not to pursue media type registration until we get the next release of JSON Schema out. There's a lot of changes happening around how the spec will be maintained and evolved and we want to work that out before we continue this process. It's ok to keep the split out JSON Schema registration around for future use, but work should be considered on-hold for that document.

Comment on lines +76 to +88
OpenAPI Specification [OAS] version 3 and above
is a consolidated standard for describing
HTTP APIs using the JSON {{!JSON=RFC8259}} and YAML [YAML] data format.

YAML media type registration is addressed in {{!YAML-MEDIATYPES=I-D.ietf-httpapi-yaml-mediatypes}},
which provides interoperability and security considerations.

OpenAPI media type registration is addressed in {{!OAS-MEDIATYPES=I-D.ietf-httpapi-rest-api-mediatypes}},
which provides interoperability and security considerations.

To increase interoperability when processing API specifications
and leverage content negotiation mechanisms when exchanging
OpenAPI Specification resources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This belongs in the OpenAPI registration, not the JSON Schema registration. I wouldn't worry about rewriting it for the purposes of this PR, but I suggest removing it and leaving it for later to add a proper introduction for JSON Schema.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we'll fix it in a future PR.

Comment on lines +24 to +30
author:
-
ins: R. Polli
name: Roberto Polli
org: Digital Transformation Department, Italian Government
email: [email protected]
country: Italy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSON Schema section of the original document was contributed by me and is now it's own document. I think that should earn me an author credit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to add you as a co-editor!
Could you write an email to the httpapi and the chairs about that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am supportive of adding Jason as an author.

@@ -79,15 +77,10 @@ OpenAPI Specification [OAS] version 3 and above
is a consolidated standard for describing
HTTP APIs using the JSON {{!JSON=RFC8259}} and YAML [YAML] data format.

YAML media type registration is addressed in {{!YAML-MEDIATYPES=I-D.ietf-httpapi-yaml-mediatypes}},
which provides interoperability and security considerations.

To increase interoperability when processing API specifications
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To increase interoperability when processing API specifications
To increase interoperability when processing API descriptions

@@ -228,13 +221,13 @@ Fragment identifier considerations:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we are going to need to be explicit here about support for fragment identifiers being either JSON pointers or component schema names.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this can be deferred to another PR, I propose to merge this and release the split documents.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will be easier to review changes once the split PR is merged.

@ioggstream ioggstream merged commit c8f3660 into main Jan 7, 2024
2 checks passed
@ioggstream ioggstream deleted the ioggstream-103 branch January 7, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants