Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set overflow-y to clip for pre #8047

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

martinthomson
Copy link
Contributor

Browsers treat an overflow: auto directive as a request to make an element scrollable, even if the element does not need it. This results in scrolling being confined to that element sometimes, such as when a document is scrolled using a mouse wheel if the document scrolls the pointer into that element. The result is that scrolling can be "trapped" on an element that doesn't really need to scroll.

This disables vertical scrolling for those pre elements that might trap scrolling in this way.

Browsers treat an overflow: auto directive as a request to make an
element scrollable, even if the element does not need it.
This results in scrolling being confined to that element sometimes,
such as when a document is scrolled using a mouse wheel
if the document scrolls the pointer into that element.
The result is that scrolling can be "trapped" on an element that
doesn't really need to scroll.

This disables vertical scrolling for those pre elements that might
trap scrolling in this way.
@martinthomson martinthomson changed the title Set overflow-y to clip for pre fix: Set overflow-y to clip for pre Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (c7f6bde) to head (b63e592).
Report is 95 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8047      +/-   ##
==========================================
+ Coverage   88.78%   88.89%   +0.10%     
==========================================
  Files         296      304       +8     
  Lines       41320    41302      -18     
==========================================
+ Hits        36687    36715      +28     
+ Misses       4633     4587      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit 1663408 into ietf-tools:main Oct 14, 2024
8 of 9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants