test: Add delay to upcoming mtg filter tests #6707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6707 +/- ##
=======================================
Coverage 88.82% 88.83%
=======================================
Files 285 285
Lines 40224 40224
=======================================
+ Hits 35730 35731 +1
+ Misses 4494 4493 -1 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
Nov 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this will fix the transient failures around the
do_upcoming_view_filter_testhelperThis is the quick-and-dirty approach - could be smarter and use a
WebDriverWaitif something unexpected is encountered, but that will require some care so let's see if this works first. Probably adds ~5 seconds to the testing time because there are 22 tests using the helper.