-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add review team setting allowing reviewers to reject assignments past the deadline #5418
Merged
Commits on Mar 25, 2023
-
Added a new review team setting
allow_reviewer_to_reject_after_deadline that will allow rejecting review requests, even after the deadline is past. Also modified that the secretary, or whoever manages the reviews is always allowed to reject the review regardless of the deadline as he/she could change the deadline anyways.
Configuration menu - View commit details
-
Copy full SHA for f7f128c - Browse repository at this point
Copy the full SHA f7f128cView commit details -
Fixed but in view_reviews (wrong variable name), added more test
cases to the test_reviews.py for different reject cases.
Configuration menu - View commit details
-
Copy full SHA for 77b969f - Browse repository at this point
Copy the full SHA 77b969fView commit details
Commits on May 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 299e03a - Browse repository at this point
Copy the full SHA 299e03aView commit details
Commits on May 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1032d45 - Browse repository at this point
Copy the full SHA 1032d45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4014e5d - Browse repository at this point
Copy the full SHA 4014e5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c17db6 - Browse repository at this point
Copy the full SHA 9c17db6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1106b13 - Browse repository at this point
Copy the full SHA 1106b13View commit details
Commits on May 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 46d1f00 - Browse repository at this point
Copy the full SHA 46d1f00View commit details
Commits on Jul 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c51e379 - Browse repository at this point
Copy the full SHA c51e379View commit details
Commits on Sep 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 767f94d - Browse repository at this point
Copy the full SHA 767f94dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.