-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean removes generated docs #3353
Clean removes generated docs #3353
Conversation
src/Idris/Package.idr
Outdated
let build = build_dir (dirs (options defs)) | ||
let docBase = build </> "docs" | ||
let docDir = docBase </> "docs" | ||
() <- do Right docfiles' <- coreLift $ listDir docDir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Can we refactor the two do-blocks in their own auxiliary function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! That sounds good, should be resolved via ccff608.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that's not quite what I meant, the two functions you put in auxiliary definitions are essentially the same, except for the file path, it would be nice to remove this redundancy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see! I think I've addressed this with d788e07.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this test is failing ...
@andrevidela I think this should be ready for you now :) |
Looks good! |
This PR enables
--clean
to remove documentation generated via--mkdoc
.This addresses one of the tasks in #1918.