fix(base): runtime-erase implicit length argument to Vect's dropElem.
#3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to call the function in more situations. It also brings its signature in line with the overloads on `List`, `List1` and `SnocList`. The previous implementation of `Data.Vect.Elem.dropElem` required the length of the `Vect` to be available at runtime. This was used in order to recurse in the case that the `Elem` is not `Here`. However, it turns out that this is not actually necessary. Idris can deduce that the tail must be non-empty if it contains an `Elem`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes it possible to call the function in more situations. It also brings its signature in line with the overloads on
List,List1andSnocList.The previous implementation of
Data.Vect.Elem.dropElemrequired the length of theVectto be available at runtime. This was used in order to recurse in the case that theElemis notHere. However, it turns out that this is not actually necessary. Idris can deduce that the tail must be non-empty if it contains anElem.Should this change go in the CHANGELOG?
CHANGELOG_NEXT.md(and potentially alsoCONTRIBUTORS.md).