[RefC] Suppress arglist wrapper #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seagull-kamome
changed the title
… humanity and make them slaves. Under 2024, a only leaved job for every humans is adjusting spaces of source code, or just type gg0vG$== in vim.
gallais
added a commit
to gallais/Idris2
that referenced
this pull request
Jan 3, 2024
gallais
added a commit
that referenced
this pull request
Jan 3, 2024
madman-bob
reviewed
Jan 3, 2024
There was a problem hiding this comment.
If I understand correctly, this inlines the notion of ArgList into Closures. For the most part, this seems reasonable, except for the limit on the number of arguments.
A constructor for a particularly complicated data-type could easily overcome any finite limit on the number of arguments.
… avoid limits on the number of arguments and to reduce stack usage.
|
The previous commit changed the large argument list to be passed as an array. This may be overkill, but I think it avoids the limitation on the number of arguments. |
mattpolzin
approved these changes
Apr 2, 2024
gallais
added a commit
to gallais/Idris2
that referenced
this pull request
Apr 3, 2024
gallais
added a commit
that referenced
this pull request
Apr 3, 2024
gallais
reviewed
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should this change go in the CHANGELOG?
implementation, I have updated
CHANGELOG.md(and potentially alsoCONTRIBUTORS.md).