Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ fix #3083 ] Fix record update with implicit args #3092

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

Alex1005a
Copy link
Contributor

Description

This PR fix #3083.
Now update of record leaves a hole only for implicit type variable.
Moreover, would it be correct to have a different behavior for auto arguments to make the following code correct?

record WithShow (ty : Type) where
  constructor MkWS
  {auto hasShow : Show ty}
  name : ty

foo : WithShow ty -> WithShow String
foo ws = { name := "meh" } ws

@Alex1005a Alex1005a marked this pull request as draft October 8, 2023 14:11
@Alex1005a Alex1005a marked this pull request as ready for review October 9, 2023 14:13
@Alex1005a
Copy link
Contributor Author

Why is the first argument needed in the getRecordType function?

@Alex1005a Alex1005a marked this pull request as draft October 9, 2023 15:00
@Alex1005a Alex1005a marked this pull request as ready for review October 10, 2023 18:22
@gallais gallais merged commit 999c404 into idris-lang:main Nov 30, 2023
22 checks passed
@Alex1005a Alex1005a deleted the fix-3083 branch November 30, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates of records with auto implicits result in unsolved holes
2 participants