[ test ] Fix package tests hygiene #3088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buzden
force-pushed
the
fix-pkg-tests-hygiene
branch
2 times, most recently
from
81aea55
to
ed32b3e
Compare
gallais
approved these changes
Oct 3, 2023
gallais
added
status: confirmed bug
|
Oh, I forgot that Windows has different dir separator, let me fix it... |
buzden
force-pushed
the
fix-pkg-tests-hygiene
branch
from
ed32b3e
to
75ace4f
Compare
|
Thankfully, this appeared to be the only problem |
|
This does fix #3084 for me. Thanks! |
|
To clarify, @gallais, this PR is ready |
|
Thanks @buzden! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to be constructive in critics of #3085. This is an alternative, a more universal fix for the package tests hygiene problem. Fixes #3084, closes #3085. I also cleaned up old or became incorrect hygiene workarounds in existing tests.
Also, some tests'
runscripts were changed due to the new style (I suppose, they were forgotten to be changed). To ease the review, I did it in a separate commit.