[ unelab ] Properly unelaborate metavariables originating from %search
#3055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks to @madman-bob for discovering this issue.
Consider the following code snippet that checks the value of
%search
and immediately quotes the checked value, logs it and runs an elaboration script that definesy : Nat
to be the sum of the quoted value with itself.When checking the value,
%search
gets elaborated into a metavariable. Currently, when unelaboration occurs during quotation, all metavariables get turned into holes, so the quoted value becomes?search
, as shown in the log:After that,
y
gets defined as?search + ?search
, leading to a compilation error:This PR fixes the issue by unelaborating metavariables into
ISearch
instead ofIHole
in case the metavariable corresponds to a definition constructed withBySearch
.