[ fix ] Only set IDRIS2_PREFIX if it is unset (fixes Issue 3022)
#3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original issue spotted and reported by scarf005 and Stefan Höck. For some reason, using `:=` instead of `?=` in the Makefile causes the second part of bootstrapping to fail. So the fix is to use `?=`. Fixes idris-lang#3022
We've modified the environment variables, but nobody seemingly bothered updating the docs. Discovered as part of idris-lang#3022
As well as the envvars doc update.
CodingCellist
added
documentation
|
Previously |
Probably sensible. On the same page, but under different subheadings? |
gallais
approved these changes
Jul 29, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discovered by scarf005 in #3022, if the
IDRIS2_PREFIXenvvar is set, bootstrapping fails. This happens regardless ofPREFIXbeing set or not, and only happens ifIDRIS2_PREFIXis set.Changing the syntax in the
Makefileto use?=(assign-if-unset) instead of:=(assign) seems to fix the issue.I also updated the
envvars.rstdocs, because they were outdated and didn't mentionPREFIXbeing a thing (something which could've avoided the issue, but also would've left it buried for someone else to unearth). There were several changes, e.g. #2649, which weren't included.Should this change go in the CHANGELOG?
implementation, I have updated
CHANGELOG.md(and potentially alsoCONTRIBUTORS.md).