Skip to content

Commit

Permalink
[ fix #72 ] remove the broken modules (#3319)
Browse files Browse the repository at this point in the history
* [ fix #72 ] remove the broken modules

People are still hitting the same issueT
There has been no movement towards fixing it
It is IMO unfixable

Let's drop it.

* [ fix #72 ] Remove dependencies of Control.Algebra

Follow-up to the commit by gallais, this removes the contrib libraries
which were using `Control.Algebra`.

* [ fix #72 ] Record changes in CHANGELOG_NEXT

* [ lint ] Move Algebra changes to existing header

---------

Co-authored-by: Thomas E. Hansen <[email protected]>
  • Loading branch information
gallais and CodingCellist authored Jun 17, 2024
1 parent 02e5468 commit 3f985bc
Show file tree
Hide file tree
Showing 10 changed files with 17 additions and 622 deletions.
17 changes: 17 additions & 0 deletions CHANGELOG_NEXT.md
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,23 @@ This CHANGELOG describes the merged but unreleased changes. Please see [CHANGELO
* Function `invFin` from `Data.Fin.Extra` was deprecated in favour of
`Data.Fin.complement` from `base`.

* The `Control.Algebra` library from `contrib` has been removed due to being
broken, unfixed for years, and on several independent occasions causing
confusion with people picking up Idris and trying to use it.
- Detailed discussion can be found in
[Idris2#72](https://github.com/idris-lang/Idris2/issues/72).
- For reasoning about algebraic structures and proofs, please see
[Frex](https://github.com/frex-project/idris-frex/) and
[idris2-algebra](https://github.com/stefan-hoeck/idris2-algebra/).

* Since they depend on `Control.Algebra`, the following `contrib` libraries have
also been removed:
- `Control/Monad/Algebra.idr`
- `Data/Bool/Algebra.idr`
- `Data/List/Algebra.idr`
- `Data/Morphisms/Algebra.idr`
- `Data/Nat/Algebra.idr`

#### Network

* Add a missing function parameter (the flag) in the C implementation of `idrnet_recv_bytes`
154 changes: 0 additions & 154 deletions libs/contrib/Control/Algebra.idr

This file was deleted.

22 changes: 0 additions & 22 deletions libs/contrib/Control/Algebra/Implementations.idr

This file was deleted.

Loading

0 comments on commit 3f985bc

Please sign in to comment.