Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing specifying liblapack. #2327

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

joshua-cogliati-inl
Copy link
Contributor

@joshua-cogliati-inl joshua-cogliati-inl commented Jun 3, 2024


Pull Request Description

What issue does this change request address?

#1806
(See also pull requests: #2260 #2251 )

What are the significant changes in functionality due to this change request?

This removes the specification of liblapack for Mac and Linux, since newer versions of liblapack work with RAVEN again.
This also forces setuptools 69 because version 70 does not work with the version of ray we use.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@moosebuild
Copy link

Job Test Ubuntu 16 on 203b38c : invalidated by @joshua-cogliati-inl

failed in fetch

@moosebuild
Copy link

Job Test mac on 203b38c : invalidated by @joshua-cogliati-inl

failed in fetch

@moosebuild
Copy link

Job Mingw Test on 203b38c : invalidated by @joshua-cogliati-inl

updated conda

1 similar comment
@moosebuild
Copy link

Job Mingw Test on 203b38c : invalidated by @joshua-cogliati-inl

updated conda

@moosebuild
Copy link

Job Test Ubuntu 20-2 Optional on 203b38c : invalidated by @joshua-cogliati-inl

updated conda

@moosebuild
Copy link

Job Test Ubuntu 18-2 Python 3 on 0e90fda : invalidated by @joshua-cogliati-inl

Diff tests/framework/PostProcessors/LimitSurface/testLimitSurfacePostProcessor

@moosebuild
Copy link

Job Mingw Test on 07fb9c9 : invalidated by @joshua-cogliati-inl

failed in fetch

@moosebuild
Copy link

Job Test qsubs sawtooth on 07fb9c9 : invalidated by @joshua-cogliati-inl

Diff tests/cluster_tests/AdaptiveSobol/test_parallel_adaptive_sobol

@joshua-cogliati-inl
Copy link
Contributor Author

Note that the windows dependency on a specific liblapack can be removed with a regold at some point in the future.

Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good.

@wangcj05
Copy link
Collaborator

wangcj05 commented Jun 5, 2024

Tests are green, checklist is good.

@wangcj05 wangcj05 merged commit ffcc94f into idaholab:devel Jun 5, 2024
12 checks passed
@joshua-cogliati-inl joshua-cogliati-inl deleted the lib_win_play branch June 5, 2024 20:18
Jimmy-INL pushed a commit that referenced this pull request Jul 7, 2024
* Removing specifying liblapack.

* Switching to setuptools 69.

* Adding comment explaining setuptools version.

* Adding back windows lapack dependency to see if needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants