-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing specifying liblapack. #2327
Conversation
Job Test Ubuntu 16 on 203b38c : invalidated by @joshua-cogliati-inl failed in fetch |
Job Test mac on 203b38c : invalidated by @joshua-cogliati-inl failed in fetch |
Job Mingw Test on 203b38c : invalidated by @joshua-cogliati-inl updated conda |
1 similar comment
Job Mingw Test on 203b38c : invalidated by @joshua-cogliati-inl updated conda |
Job Test Ubuntu 20-2 Optional on 203b38c : invalidated by @joshua-cogliati-inl updated conda |
Job Test Ubuntu 18-2 Python 3 on 0e90fda : invalidated by @joshua-cogliati-inl Diff tests/framework/PostProcessors/LimitSurface/testLimitSurfacePostProcessor |
Job Mingw Test on 07fb9c9 : invalidated by @joshua-cogliati-inl failed in fetch |
Job Test qsubs sawtooth on 07fb9c9 : invalidated by @joshua-cogliati-inl Diff tests/cluster_tests/AdaptiveSobol/test_parallel_adaptive_sobol |
Note that the windows dependency on a specific liblapack can be removed with a regold at some point in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good.
Tests are green, checklist is good. |
* Removing specifying liblapack. * Switching to setuptools 69. * Adding comment explaining setuptools version. * Adding back windows lapack dependency to see if needed.
Pull Request Description
What issue does this change request address?
#1806
(See also pull requests: #2260 #2251 )
What are the significant changes in functionality due to this change request?
This removes the specification of liblapack for Mac and Linux, since newer versions of liblapack work with RAVEN again.
This also forces setuptools 69 because version 70 does not work with the version of ray we use.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.