Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in input. #1913

Merged
merged 4 commits into from
Jul 28, 2022
Merged

Fix typo in input. #1913

merged 4 commits into from
Jul 28, 2022

Conversation

joshua-cogliati-inl
Copy link
Contributor

@joshua-cogliati-inl joshua-cogliati-inl commented Jul 26, 2022


Pull Request Description

What issue does this change request address?

#1806

What are the significant changes in functionality due to this change request?

Fixes typo that was causing test failure.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@moosebuild
Copy link

Job Test Fedora 32 on 190688f : invalidated by @joshua-cogliati-inl

Failed tests/framework/unit_tests/CustomDrivers/demo_python_raven

wangcj05
wangcj05 previously approved these changes Jul 26, 2022
@moosebuild
Copy link

Job Mingw Test on 190688f : invalidated by @wangcj05

1 similar comment
@moosebuild
Copy link

Job Mingw Test on 190688f : invalidated by @wangcj05

@moosebuild
Copy link

Job Mingw Test on 190688f : invalidated by @joshua-cogliati-inl

failed to finish

@moosebuild
Copy link

Job Mingw Test on 190688f : invalidated by @joshua-cogliati-inl

Failed ( 5.81sec)doc/workshop\reducedOrderModeling\inputs\examples\loadAndSamplePretrained

@moosebuild
Copy link

Job Mingw Test on ca8b77c : invalidated by @joshua-cogliati-inl

Diff tests/framework/PostProcessors/LimitSurface/testLimitSurfacePostProcessor

Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. No code changes, but some updates on tests.

@wangcj05
Copy link
Collaborator

checklist is good, and changes have been approved. PR can be merged.

@wangcj05 wangcj05 merged commit f8287ae into idaholab:devel Jul 28, 2022
@joshua-cogliati-inl joshua-cogliati-inl deleted the fix_typo branch July 28, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants