Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure validation pp manual #1818

Merged
merged 3 commits into from
Apr 25, 2022

Conversation

wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented Apr 22, 2022


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

See #1806

What are the significant changes in functionality due to this change request?

Right now, the validation post-processors description in user manual is not very clear. This PR will restructure the validation post-processors section to make it easy to read.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Jimmy-INL
Jimmy-INL previously approved these changes Apr 22, 2022
@moosebuild
Copy link

Job Test qsubs sawtooth on 41cbad8 : invalidated by @wangcj05

tests/cluster_tests/RavenRunsRaven/Code

@moosebuild
Copy link

Job Test qsubs sawtooth on 41cbad8 : invalidated by @wangcj05

mkdir: cannot create directory ‘/scratch’: Stale file handle

@wangcj05
Copy link
Collaborator Author

@Jimmy-INL I have rebased this PR, and now this PR is ready for you to review. Please let me know if you have any comments.

@moosebuild
Copy link

Job Mingw Test on 6fc48da : invalidated by @joshua-cogliati-inl

civet hasn''t started.

@moosebuild
Copy link

Job Test qsubs sawtooth on 6fc48da : invalidated by @joshua-cogliati-inl

restarted civet

@wangcj05
Copy link
Collaborator Author

@Jimmy-INL This PR is ready for you to review. Tests are green now.

@Jimmy-INL
Copy link
Collaborator

The PR only includes manual changes and resturcturing.

@Jimmy-INL Jimmy-INL merged commit 2fb61b9 into idaholab:devel Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants