-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trpc #467
base: master
Are you sure you want to change the base?
Conversation
There's a bug with the schedule: the name of the current quarter ("Summerwk2") does not match the name of the terms in the WebSoc current quarter ("Summer Week 2"), so there is a bug in the getTermDeptNum route in the schedule router. |
Reviews and roadmap not migrated yet |
import * as trpcExpress from '@trpc/server/adapters/express'; | ||
import { TRPCError, initTRPC } from '@trpc/server'; | ||
|
||
export const createContext = ({ req, res }: trpcExpress.CreateExpressContextOptions) => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something with this type here is throwing a typescript error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why it says Property 'session' does not exist on type 'Request<ParamsDictionary, any, any, ParsedQs, Record<string, any>>
but the property definitely does exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(req as Request).session
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Express.Request.session: Session & Partial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { Request } from 'express';
import { Session, SessionData } from 'express-session';
import '../types/types';
session: (req as Request & { session: Session & Partial<SessionData> }).session,
Description
Screenshots
Steps to verify/test this change:
Final Checks:
(optional)
Issues
Closes #460