Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ add study room scraper and availability endpoint #143

Merged
merged 16 commits into from
May 20, 2024
Merged

feat: ✨ add study room scraper and availability endpoint #143

merged 16 commits into from
May 20, 2024

Conversation

cokwong
Copy link
Contributor

@cokwong cokwong commented May 1, 2024

Summary

  • Add scraper for study rooms endpoint v1/rest/studyRooms
    • Requires params location, start and end
    • Available study locations:
      • Langson
      • Gateway
      • Science
      • MRC
      • GML
    • Date params uses (YYYY-MM-DD) format
  • All study rooms can be retrieved using v1/rest/studyRooms/all (still requires start and end)
  • Update GraphQL to supports new endpoints.
  • DB will need to be updated for new schema.

Issues

Closes #39.

cokwong and others added 11 commits April 10, 2024 16:21
@cokwong
feat(tools): ✨ setup study room scraper files
17d06d7
@cokwong
feat(tools): add starter code to study room scraper
55380cc
@cokwong
feat(tools): add helper method to request study room spaces
2dda3e0
@cokwong
feat: added a getRoomIds function to scrape uci libraries' study room…
df0cac4 
…s. CURRENTLY NOT WORKING

BREAKING CHANGE: The getRoomIds function does not return accurate data from the website
@cokwong
feat: added a getRoomInfo function which takes a room ID and creates …
bd5f668 
…a room object from it
@cokwong
feat(study-room-scraper): add study room info scraper
a7295a0
@cokwong
feat(study-room-scraper): ✨ add prisma schema for study spaces
f18148d
@cokwong
refactor(study-room-scraper): ♻️ clean up files
67c490b
@cokwong
feat(study-room-scraper): ✨ define prisma schema
a11fddb
fix: 🐛 fixed room scraper to get full description
f205fab
@cokwong
feat(study-rooms): ✨ implement study room endpoints
70addf5
@cokwong cokwong linked an issue May 1, 2024 that may be closed by this pull request
Study room availability scraper #39
Closed
@cokwong cokwong temporarily deployed to staging-143 May 1, 2024 07:14 — with GitHub Actions Inactive
@cokwong cokwong temporarily deployed to staging-143-docs May 1, 2024 07:14 — with GitHub Actions Inactive
@cokwong cokwong temporarily deployed to staging-143-docs May 1, 2024 08:12 — with GitHub Actions Inactive
@cokwong cokwong temporarily deployed to staging-143 May 1, 2024 08:12 — with GitHub Actions Inactive
@cokwong cokwong temporarily deployed to staging-143-docs May 1, 2024 08:14 — with GitHub Actions Inactive
@cokwong cokwong temporarily deployed to staging-143 May 1, 2024 08:14 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-143 May 15, 2024 15:48 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-143-docs May 15, 2024 15:48 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-143 May 15, 2024 15:58 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-143-docs May 15, 2024 15:58 — with GitHub Actions Inactive
ap0nia
ap0nia requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@ap0nia ap0nia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! 👏

I can take a look and clean everything up myself. The code makes sense, and well thought out.

apps/api/src/routes/v1/rest/studyRooms/+endpoint.ts Outdated Show resolved Hide resolved
apps/api/src/routes/v1/rest/studyRooms/lib.ts Outdated Show resolved Hide resolved
apps/api/src/routes/v1/rest/studyRooms/lib.ts Outdated Show resolved Hide resolved
apps/api/src/routes/v1/rest/studyRooms/lib.ts Outdated Show resolved Hide resolved
apps/api/src/routes/v1/rest/studyRooms/{id}/+endpoint.ts Outdated Show resolved Hide resolved
tools/study-room-scraper/src/study-room-scraper.ts Outdated Show resolved Hide resolved
tools/study-room-scraper/src/study-room-scraper.ts Outdated Show resolved Hide resolved
tools/study-room-scraper/src/study-room-scraper.ts Outdated Show resolved Hide resolved
tools/study-room-scraper/src/study-room-scraper.ts Outdated Show resolved Hide resolved
tools/study-room-scraper/src/study-room-scraper.ts Outdated Show resolved Hide resolved
@sanskarm7 sanskarm7 temporarily deployed to staging-143 May 20, 2024 06:50 — with GitHub Actions Inactive
@sanskarm7 sanskarm7 temporarily deployed to staging-143-docs May 20, 2024 06:50 — with GitHub Actions Inactive
@cokwong cokwong temporarily deployed to staging-143 May 20, 2024 16:53 — with GitHub Actions Inactive
@cokwong cokwong temporarily deployed to staging-143-docs May 20, 2024 16:53 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy requested a review from ap0nia May 20, 2024 18:06
ap0nia
ap0nia approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@ap0nia ap0nia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@ecxyzzy ecxyzzy merged commit cf565b3 into main May 20, 2024
4 checks passed
@ecxyzzy ecxyzzy deleted the study-room-scraper branch May 20, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ap0nia ap0nia ap0nia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Study room availability scraper
4 participants
@cokwong @ap0nia @sanskarm7 @ecxyzzy