Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter Items on Map and Results Bar #17

Merged
merged 3 commits into from
May 19, 2024
Merged

Filter Items on Map and Results Bar #17

merged 3 commits into from
May 19, 2024

Conversation

rebecca-123
Copy link
Contributor

@rebecca-123 rebecca-123 commented May 19, 2024 •
edited
Loading

  • Removed search condition from filterItem, since items are already filtered by search beforehand.
  • Also changed Marker key from item.location to item.id, because there were previously console errors about two items having the same location (key).
  • Moved filterItem to Utils.js so we only have one copy of the function

NwinNwin
NwinNwin approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@NwinNwin NwinNwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NwinNwin NwinNwin merged commit 3b99c06 into main May 19, 2024
1 check passed
@NwinNwin NwinNwin deleted the item-filter branch May 19, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NwinNwin NwinNwin NwinNwin approved these changes

@stevem-zhou stevem-zhou Awaiting requested review from stevem-zhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebecca-123 @NwinNwin