Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create app drawer #12

Merged
merged 20 commits into from
Jan 19, 2024
Merged

feat: create app drawer #12

merged 20 commits into from
Jan 19, 2024

Conversation

MinhxNguyen7
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 commented Dec 23, 2023

Description

Add a drawer (thing that comes in from the side) with relevant buttons and information. The drawer is a sidebar on sufficiently-side devices

Includes:

  • User icon and name at the top.
  • Link to settings page.
  • Link to summary view.
  • Link to feedback at the bottom.
  • Link to about page at bottom?
  • Link to GitHub at the bottom?

Deadline

I plan to finish this by Monday, 25 December.

TODOs

  • Make sidebar.
  • Add user profile and name
  • Add buttons.
  • Turn sidebar into drawer.
  • Style drawer.

@MinhxNguyen7 MinhxNguyen7 added the enhancement New feature or request label Dec 23, 2023
@MinhxNguyen7 MinhxNguyen7 self-assigned this Dec 23, 2023
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-12 December 23, 2023 02:17 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-12 December 23, 2023 03:46 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 marked this pull request as draft December 23, 2023 03:47
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-12 December 25, 2023 20:27 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-12 December 26, 2023 06:19 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-12 December 26, 2023 07:01 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 marked this pull request as ready for review December 26, 2023 07:01
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-12 December 26, 2023 07:11 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-12 December 26, 2023 07:54 — with GitHub Actions Inactive
Copy link
Member

@KevinWu098 KevinWu098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks solid. Just some comments on styling and consistency.

src/lib/components/Header/Header.svelte Outdated Show resolved Hide resolved
src/lib/components/Header/Header.svelte Outdated Show resolved Hide resolved
src/lib/components/SideBar/SideBarFooter.svelte Outdated Show resolved Hide resolved
src/lib/components/SideBar/SideBar.svelte Show resolved Hide resolved
src/lib/components/SideBar/SideBar.svelte Show resolved Hide resolved
src/lib/components/SideBar/SideBar.svelte Outdated Show resolved Hide resolved
src/lib/components/SideBar/SideBarLink.svelte Show resolved Hide resolved
src/lib/components/SideBar/SideBarLink.svelte Outdated Show resolved Hide resolved
src/lib/components/Header/Header.svelte Outdated Show resolved Hide resolved
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-12 January 15, 2024 07:21 — with GitHub Actions Inactive
Copy link
Member

@KevinWu098 KevinWu098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good except for a quick question on the sizing of the sidebar. IMO it's a little large. Thoughts? Actually, on further consideration, it's kinda growing on me.

Though I will ask about whether or not the sidebar should be right aligned in mobile view. 👀

@MinhxNguyen7
Copy link
Member Author

I do agree the sidebar's a little big, but I couldn't quickly find a way to fix it, so I'm leaving that for the future.

I put the sidebar on the right because I can't put the hamburger menu on the left because the icon's there, but I'm open to suggestions.

Are these your only concerns?

Copy link
Member

@KevinWu098 KevinWu098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling considerations can be addressed later; LGTM

@MinhxNguyen7 MinhxNguyen7 merged commit 3927667 into main Jan 19, 2024
2 checks passed
@MinhxNguyen7 MinhxNguyen7 linked an issue Jan 19, 2024 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App drawer
2 participants