Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema updates/menu.get #97

Merged
merged 23 commits into from
Feb 5, 2024
Merged

Schema updates/menu.get #97

merged 23 commits into from
Feb 5, 2024

Conversation

anmho
Copy link
Collaborator

@anmho anmho commented Feb 3, 2024 •
edited
Loading

Chores

  • Moved utils to a separate package under @zotmeal/utils
  • Updated initial prisma schema
  • Started creating menu.get tRPC procedure
  • Created basic tests for menu.parse on sample data using vitest

dlustre and others added 17 commits February 2, 2024 15:48
@dlustre
feat: mvp parser
923d18a
@dlustre
refactor: move parse into the menuRouter
6f0f817
@dlustre
refactor: move parse function to its own file
423192c
@dlustre
refactor: replace interfaces with zod schemas
a516415
@dlustre
refactor: separate campusdish schemas and zotmeal schemas into their …
5e56194 
…own files
@dlustre
refactor: clean up code, imports, and file locations
3a9e36a 
Changes: (courtesy of andy's suggestions 👍)
- add @acme/utils module to api deps
- move parse.ts to api package
- replace relative path imports with aliased ones
- define CampusDishResponse.LocationId to only be 3314 or 3056
@anmho
creating zod schema for menu.get procedure
d9c6ca7
@anmho
creating zod schema for menu.get procedure
837db9e
@anmho
Merge 'campusdish-parser'
da0f563
@anmho
Update README.md
006ede4
@dlustre
update zod schemas to match models from #92
e874a1a
@dlustre
replace @acme alias with @zotmeal
d7be912
@KatyH820
fix: update import for local and switch to Google CampusDish URL
02f64b0
@dlustre
chore: update pnpm-lock.yaml
de01321
@dlustre
Merge pull request #96 from icssc/campusdish-parser-katy
7468042 
fix: update import for local and switch to Google CampusDish URL
@anmho
chore: created utils package and moved parse
3445550
@KatyH820
Merge pull request #89 from icssc/campusdish-parser
c554e83 
Create Campus Dish Parser
@anmho anmho changed the title Get menu Schema updates/menu.get Feb 3, 2024
bjsilva1

This comment was marked as outdated.

Sign in to view

@anmho anmho marked this pull request as draft February 4, 2024 23:05
@anmho anmho marked this pull request as ready for review February 5, 2024 03:42
@anmho anmho merged commit 158309a into data-model Feb 5, 2024
1 of 4 checks passed
@anmho anmho deleted the get-menu branch February 5, 2024 03:43
@bjsilva1 bjsilva1 mentioned this pull request Feb 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjsilva1 bjsilva1 bjsilva1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anmho @bjsilva1 @dlustre @KatyH820