Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3246: Choppy scrolling when scrolling fast after smooth scrolling introduction #3248

Merged
merged 4 commits into from
Aug 3, 2024

Conversation

tom-englert
Copy link
Contributor

#3246

Problem

Choppy scrolling when scrolling fast after smooth scrolling introduction

Solution

Update TomsToolbox.Wpf package with fixed behavior.

@christophwille
Copy link
Member

@ElektroKill Can you please give the PR's action build artefacts a try?

@ElektroKill
Copy link
Contributor

I've compiled the build from the source and here are my observations:

  • The smoothness of the scrolling is greatly improved
  • The scrolling appears to be WAY faster than before (scrolling many more lines of text per scroll operation)
  • The number of lines scrolled per scroll operation no longer matches what is configured in Windows scrolling speed settings

I have my Windows settings so that one scroll = 3 lines. Before the smooth scrolling changes it would scroll 3 lines, now it scrolls around 36 lines which is quite an increase. This increase in scrolling affects other components, such as the treeview.

@tom-englert
Copy link
Contributor Author

@ElektroKill can you try the latest version? Should now cover all different scenarios.

@ElektroKill
Copy link
Contributor

I took a look at the latest commit and the scrolling in the main text view seems to behave correctly when it comes to how much a single scroll operation is scrolling, however, the smoothness is back to what it used to be before the smooth scrolling changes.

When it comes to scrolling in the Treeview, I can observe some weird jumping and snapping occasionally when the Treeview will jump/scroll much further than expected. This can be observed in the video found below.

Throughout the video, I'm scrolling with the same speed on the scroll wheel. First, the behavior in the latest build from this PR is demonstrated, and later a build from before any of the scrolling changes is shown.
https://www.youtube.com/watch?v=8v7dLZ8LfQ0

@tom-englert
Copy link
Contributor Author

tom-englert commented Aug 2, 2024

It's now also activated on the test view.

What you call "jumping" and "snapping" is a dynamic acceleration when you turn the mouse wheel very fast, to make it easier to scroll large lists.

@ElektroKill
Copy link
Contributor

I can confirm the smooth scrolling is now working in the text view.

Regarding the dynamic acceleration? Would it be possible to add an option in settings to enable/disable it? I'm really not a fan of mouse pointer acceleration and scrolling acceleration as in my opinion it makes things more unpredictable.

@tom-englert
Copy link
Contributor Author

@ElektroKill I just removed it

@christophwille
Copy link
Member

Thanks for sorting out smooth scrolling!

@christophwille christophwille merged commit 7e74de2 into icsharpcode:master Aug 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants