SharpTreeView: Split into ILSpyX.TreeView and ILSpy.Controls.TreeView #3240
Conversation
…rm by proxying System.Windows dependencies
christophwille
force-pushed
the
cw/stnpoc
branch
from
4bd46c4
to
52256fd
Compare
|
@Rpinski please add your comments from the viewpoint of the ilspy-vscode extension @jmacato @maxkatz6 from the point of view of Avalonia / Avalonia XPF - would such a tree node move/change as outlined in the issue comment plus this PoC PR be in line with that architecture or do the IPlatform* abstractions completely run counter what Avalonia would need? |
|
Hi @christophwille ! The changes looks fine for my perspective on XPF, as it just abstracts out the needed interfaces for the treenode controls. |
|
From the view of ilspy-vscode, what I'm interested in is:
It looks like this approach would deliver all of that. I don't need anything related to UI interactions like Drag&Drop or cut/copy support. But I don't think that would harm as long as any dependencies on UI frameworks are abstracted away. That needs some more effort. |
…indows-dependent classes to ILSpy/Controls/TreeView
christophwille
changed the title
| { | ||
| public interface IPlatformDragDrop | ||
| { | ||
| XPlatDragDropEffects DoDragDrop(object dragSource, object data, XPlatDragDropEffects allowedEffects); |
There was a problem hiding this comment.
Note: this and other DnD operations should be async, as they are async in nature.
On desktop (and Browser with multithreading and hacks enabled), we can solve it by using DispatcherFrame to sync-wait on async operations. But since you are refactoring this part, consider making it async from the start as well.
There was a problem hiding this comment.
Note, DispatcherFrame is usable with both XPF and pure Avalonia. That's what I was using so far in new port too.
There was a problem hiding this comment.
Except mobile, Avalonia doesn't have any way to use DispatcherFrame on mobile yet. But I assume ILSpy won't benefit much from mobile support either way. Browser might be useful though.
There was a problem hiding this comment.
Ah, interesting - I was only reshuffling existing code, and there DoDragDrop was used in exactly that fashion.
ILSpy/MainWindow.xaml
Outdated
| @@ -144,7 +146,8 @@ | |||
| <Style TargetType="{x:Type MenuItem}" BasedOn="{StaticResource {x:Type MenuItem}}"> | |||
| <Setter Property="Command" Value="{x:Static local:ILSpyCommands.SetTheme}" /> | |||
| <Setter Property="CommandParameter" Value="{Binding}" /> | |||
| <Setter Property="IsCheckable" Value="True" /> <!-- Required by AvalonDock's MenuItem style to show the checkmark --> | |||
| <Setter Property="IsCheckable" Value="True" /> | |||
There was a problem hiding this comment.
Comment was moved to the wrong line...
…icsharpcode#3240) * Changes necessary for making SharpTreeNode cross platform by proxying System.Windows dependencies * Add ITreeNodeImagesProvider for node icons * Move InternalsVisibleTo to csproj (possible since net50) * Move view models and other xplat class for SharpTreeView to ILSpyX, Windows-dependent classes to ILSpy/Controls/TreeView * Move GetDoubleClickTime to NativeMethods
#3172 (comment)
This is the basics - splitting xplat and WPF-specific parts of SharpTreeView and distribute to ILSpyX and ILSpy projects respectively.