Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle C# ref return when converting VB->C# #1116

Merged
merged 9 commits into from
Jul 22, 2024
Merged

Handle C# ref return when converting VB->C# #1116

merged 9 commits into from
Jul 22, 2024

Commits on Jul 18, 2024

  1. add tests 

    * WithByRef test commented out because of a Roslyn bug (need newer version)
* A bunch of unrelated changes was necessary to fix tests
* `ConvertWholeSolutionAsync` (to VB) doesn't work because it writes stack including file names
    Timur Kelman authored and Timur Kelman committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    4cb9a8f View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. add a test for a ref-returning non-default property

    Timur Kelman authored and Timur Kelman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    625b8b1 View commit details
    Browse the repository at this point in the history

  2. recognize ref return properties when processing ByRef arguments

    Timur Kelman authored and Timur Kelman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    0e79753 View commit details
    Browse the repository at this point in the history

  3. adjust other tests

    Timur Kelman authored and Timur Kelman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    4575a35 View commit details
    Browse the repository at this point in the history

  4. actually recognize ref return properties when processing ByRef arguments

    Timur Kelman authored and Timur Kelman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    807d815 View commit details
    Browse the repository at this point in the history

  5. exclude CSharpRefReturn project from ConvertWholeSolutionAsync (to VB) 

    It can never be converted because of the ref return properties
    Timur Kelman authored and Timur Kelman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    f3497e3 View commit details
    Browse the repository at this point in the history

  6. add tests for With ref-return properties

    Timur Kelman authored and Timur Kelman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    79d6f8a View commit details
    Browse the repository at this point in the history

  7. consider OperationKind.PropertyReference assignable if ReturnsByRef

    Timur Kelman authored and Timur Kelman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b5ac515 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Exclude tests until there's a working version of codeanlaysis

    @GrahamTheCoder
    GrahamTheCoder committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    4a85f8b View commit details
    Browse the repository at this point in the history