forked from ibriz/cps_java_contracts
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/compromised wallet with no milestone progressreport #24
Merged
naneey
merged 50 commits into
main
from
fix/compromised-wallet-with-no-milestone-progressreport
Jan 25, 2024
Merged
Fix/compromised wallet with no milestone progressreport #24
naneey
merged 50 commits into
main
from
fix/compromised-wallet-with-no-milestone-progressreport
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Request to update CPS contracts
…line-fix Check for milestone approved added in milestone deadline getter
…' into fix/contributor-project-getters
…tters Fix for getters related to contributor project and sponsor deposited bond
Fix for getRemainingProject
…ress-for-compromised-wallets Fix for updating compromised address
…' into featue/add-block-address-method-for-compromised-wallets
…ethod-for-compromised-wallets Featue/add block address method for compromised wallets
…-with-no-milestones fix: No vote required for progress-report without milestones
This was
linked to
issues
Jan 25, 2024
naneey
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
sdpisreddevil
deleted the
fix/compromised-wallet-with-no-milestone-progressreport
branch
January 25, 2024 17:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Updated contributor and sponsor addresses in case of any compromise or unauthorized access to CPS wallets. This ensures that compromised wallets are blocked.
Fixed the voting error for progress reports without any submitted milestone. Now, progress reports without milestones can be voted on without errors.
Fixed readonly methods on loginPrep to address the issue where candidate preps cannot vote during the voting period. The list is now correctly taken from the snapshot database.
Fixed readonly method on CPSTreasury. The outstanding estimated amount is now displayed correctly for both contributors and sponsors.
Added the remainingMilestones API to provide visibility on remaining milestones. This enhancement is designed to improve the frontend user experience.
Purpose:
This pull request addresses several issues and introduces improvements to enhance the functionality and security of the CPS system. The changes aim to provide a more robust and user-friendly experience for contributors, sponsors, and validators.
Testing:
All changes have been thoroughly tested to ensure proper functionality and to verify that the identified issues have been resolved. Automated tests have been added where applicable to maintain code quality and prevent regressions.
Additional Notes:
Please review and test the changes thoroughly. The proposed updates enhance the overall reliability and usability of the CPS system.