Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/compromised wallet with no milestone progressreport #24

Merged
merged 50 commits into from
Jan 25, 2024
Merged

Fix/compromised wallet with no milestone progressreport #24

merged 50 commits into from
Jan 25, 2024

Conversation

sdpisreddevil
Copy link
Collaborator

Changes:

Updated contributor and sponsor addresses in case of any compromise or unauthorized access to CPS wallets. This ensures that compromised wallets are blocked.

Fixed the voting error for progress reports without any submitted milestone. Now, progress reports without milestones can be voted on without errors.

Fixed readonly methods on loginPrep to address the issue where candidate preps cannot vote during the voting period. The list is now correctly taken from the snapshot database.

Fixed readonly method on CPSTreasury. The outstanding estimated amount is now displayed correctly for both contributors and sponsors.

Added the remainingMilestones API to provide visibility on remaining milestones. This enhancement is designed to improve the frontend user experience.

Purpose:

This pull request addresses several issues and introduces improvements to enhance the functionality and security of the CPS system. The changes aim to provide a more robust and user-friendly experience for contributors, sponsors, and validators.

Testing:

All changes have been thoroughly tested to ensure proper functionality and to verify that the identified issues have been resolved. Automated tests have been added where applicable to maintain code quality and prevent regressions.

Additional Notes:
Please review and test the changes thoroughly. The proposed updates enhance the overall reliability and usability of the CPS system.

naneey and others added 26 commits January 7, 2024 21:23
@naneey
chore: checked milestone status for getting milestone deadline
4e9a7bb
@naneey
test: last progress report test case added
75024a1
@0xGojo
added method to update contributor's address
5c5489b
@0xGojo
removed comment.
bea983c
@0xGojo
new contributor must not contract addr.
e316452
@naneey
changes for getRemainingProject
62a35c4
@naneey
getter fixed for sponsor's bond and initial payment
a7fd91d
@naneey
linter removed
29d7fc0
@sdpisreddevil
fix:
0279a58 
No vote required for progress-report without milestones
@naneey
Merge branch 'fix/update-contributor-address-for-compromised-wallets'…
9b1b979 
… into main
@naneey
Merge pull request #19 from 0xGojo/main
b837bc6 
Request to update CPS contracts
@naneey
fix for contributor and sponsor address
327692e
@sdpisreddevil
fix:
f507b6d 
add block address for compromised wallet condition and stop that wallet to claim any fund from CPS
@sdpisreddevil
fix:
2f7e6fb 
add check maintenance mode for claiming the reward in case of any compromise case
@naneey
test: unit test for getters fixed
9dacf52
@naneey
chore: getter for remaining milestones
9859573
@sdpisreddevil
fix:
b6bf2e5 
update contributor as well as sponsor address for the compromised wallet
@sdpisreddevil
fix:
f0847ca 
update contributor as well as sponsor address for the compromised wallet from CPSTreasury
@sdpisreddevil
fix:
d5b1540 
update sponsor address as optional for both CPS and CPSTreasury
@sdpisreddevil
fix: update periodCount of proposal only after the proposal approval
68c568e
@naneey
chore: milestone installment amount show in cps treasury
3770752
@naneey
chore: milestone installment amount show in cps treasury
d3c2d70
@naneey
test: installment amount test fixed
9dd738c
@naneey
chore: milestone whose reports are aprroved is not added to the deadl…
7dbbfaa 
…ine list
@sdpisreddevil
Merge pull request #23 from icon-community/fix/last-PR-milestone-dead…
77f985a 
…line-fix

Check for milestone approved added in milestone deadline getter
@naneey
Merge branch 'fix/compromised-wallet-with-no-milestone-progressreport…
2867aa3 
…' into fix/contributor-project-getters
@sdpisreddevil
Merge pull request #22 from icon-community/fix/contributor-project-ge…
5674745 
…tters

Fix for getters related to contributor project and sponsor deposited bond
@sdpisreddevil
Merge pull request #21 from icon-community/fix/remaining_projects
eaa9872 
Fix for getRemainingProject
sdpisreddevil and others added 20 commits January 25, 2024 15:35
@sdpisreddevil
Merge pull request #27 from icon-community/fix/update-contributor-add…
dabdd35 
…ress-for-compromised-wallets

Fix for updating compromised address
@sdpisreddevil
Merge branch 'fix/compromised-wallet-with-no-milestone-progressreport…
6b3d2b2 
…' into featue/add-block-address-method-for-compromised-wallets
@sdpisreddevil
Merge pull request #26 from icon-community/featue/add-block-address-m…
cec00c8 
…ethod-for-compromised-wallets

Featue/add block address method for compromised wallets
@sdpisreddevil
Merge pull request #25 from icon-community/fix/progress-report-voting…
494cf3e 
…-with-no-milestones

fix: No vote required for progress-report without milestones
@naneey
chore: logic changed while checking for milestone deadline in submiss…
d86697a 
…ion array
@naneey
fix: closing bracket added
456b68e
@sdpisreddevil
fix:
d736784 
remove unused import
remove migration method
@sdpisreddevil
fix: correct spelling for variable and method name
a4535b1
@naneey
chore: contributor and sponsor set in proposal db
37ea68f
@naneey
test: unit test added for updating address
174a93a
@sdpisreddevil
fix:
aa562c4 
- add checker for the new contributor to be blocked before address update
- add checker for the new sponsor address to be blocked before address update
- add/remove whitespaces
@sdpisreddevil
fix:
b485f1c 
- add test for checker for the new contributor to be blocked before address update
- add test for checker for the new sponsor address to be blocked before address update
@sdpisreddevil
fix:
524d63e 
- variable to retrieve the ArrayDb
@sdpisreddevil
remove:
162e9d3 
- unused test file
@sdpisreddevil
fix: readonly method for blockAddress
55f86ba
@sdpisreddevil
fix: eventlog outside the loop
fcf7eff
@sdpisreddevil
fix: remove from validPreps after the address is blocked
a29af90
@sdpisreddevil
fix:
4432556 
- stop block address to submit and vote proposal/progress-report on cps
@sdpisreddevil
update: build version for both contract
dc07f10
@sdpisreddevil
update: fix CPSCore tests
39727b2
@naneey naneey self-requested a review January 25, 2024 17:42
This was linked to issues Jan 25, 2024
Fail to vote proposal being a Validator (ValidPrep) icon-community/CPS#111
Closed
Wrong Sponsor Reward amount on Dashboard icon-community/CPS#110
Closed
Wrong next disbursement amount on Dashboard icon-community/CPS#109
Closed
Progress Report Voting Error icon-community/CPS#108
Closed
bug: outstanding votes shown incorrectly icon-community/CPS#95
Closed
Change contributor wallet to another one icon-community/CPS#98
Closed
naneey
naneey approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@naneey naneey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@naneey naneey merged commit 2724e9a into main Jan 25, 2024
@sdpisreddevil sdpisreddevil deleted the fix/compromised-wallet-with-no-milestone-progressreport branch January 25, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naneey naneey naneey approved these changes

Assignees

@sdpisreddevil sdpisreddevil

@naneey naneey

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@sdpisreddevil @naneey @0xGojo