chore: fixed for loop

icon-community · Oct 16, 2023 · 5f15abc · 5f15abc
1 parent a356229
commit 5f15abc
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/CPSCore/src/main/java/community/icon/cps/score/cpscore/CPSCore.java b/CPSCore/src/main/java/community/icon/cps/score/cpscore/CPSCore.java
@@ -864,19 +864,20 @@ public void submitProgressReport(ProgressReportAttributes progressReport) {
                 " --> Progress Report Submitted Successfully.");
     }
 
-    public boolean isAllElementPresent(MilestoneVoteAttributes[] vote, ArrayDB<Integer> submitted){ // TODO: bug here fix
-        boolean status = false;
+    public boolean isAllElementPresent(MilestoneVoteAttributes[] vote, ArrayDB<Integer> submitted){
         for (int i = 0; i < submitted.size(); i++) {
-            for (MilestoneVoteAttributes v: vote) {
-                if ((v.id == submitted.get(i))){
-                    status = true;
-                }
-                else {
-                    status = false;
+            boolean found = false;
+            for (MilestoneVoteAttributes v : vote) {
+                if (v.id == submitted.get(i)) {
+                    found = true;
+                    break;
                 }
             }
+            if (!found) {
+                return false;
+            }
         }
-        return status;
+        return true;
     }