Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Electron] Fixes and Adjustments #2041

Merged
merged 7 commits into from
Apr 27, 2024
Merged

Conversation

Scavanger
Copy link
Contributor

@Scavanger Scavanger commented Apr 26, 2024

  • MacOS:

    • Nice icon for DMG
    • Fix bug when Configurator was minimized and dock icon is clicked
  • Fix (Workaround): After a MessageBox (alert()) was displayed, all input fields stopped working.

  • Fix Blackbox tab (save data flash)

  • Removed useless MSC button in blackbox tab

  • Adjust Readme

  • Add context menu (copy and paste, undo, redo)

  • Fix LED Tab

  • Fix Github Actions (What still worked yesterday. )

MacOS:
- Nice icon for DMG
- Fix bug when Configurator was minimized and dock icon is clicked

Fix (Workaround):  After a MessageBox (alert()) was displayed, all input fields stopped working.
@Scavanger Scavanger changed the title [Electron] MacOs and MessageBox fix [Electron] Fixes and Adjustments Apr 26, 2024
@Jetrell
Copy link

Jetrell commented Apr 27, 2024

Thank you for the fixes @Scavanger

I found other issues that I'm not sure if you're aware of with the Windows build.
When attempting to load a previously saved mission file from a js build.. Or even save a mission file that has been made with the electron build.
This log error occurred. error reading file (xml2js not found)

@DzikuVx DzikuVx added this to the 8.0 milestone Apr 27, 2024
@Scavanger
Copy link
Contributor Author

Thank you for the fixes @Scavanger

I found other issues that I'm not sure if you're aware of with the Windows build. When attempting to load a previously saved mission file from a js build.. Or even save a mission file that has been made with the electron build. This log error occurred. error reading file (xml2js not found)

Thanks for finding it. Fixed.

@mmosca
Copy link
Collaborator

mmosca commented Apr 27, 2024

Not exactly related, but is it possible to use https://github.com/electron/universal to distribute a single universal binary application, instead of separate x64 and arm64?

@Scavanger
Copy link
Contributor Author

Not exactly related, but is it possible to use https://github.com/electron/universal to distribute a single universal binary application, instead of separate x64 and arm64?

I have already tried this in the GitHub Actions, but unfortunately it always cancelled with the following error message:

✖ Stitching darwin/x64 and darwin/arm64 into a darwin/universal package [FAILED: While trying to merge mach-o files across your apps we found a mismatch, the number of mach-o files is not the same between the arm64 and x64 builds]

I'm not a Mac expert if you know how to fix the error, please feel free.

@DzikuVx
Copy link
Member

DzikuVx commented Apr 27, 2024

let's merge and have incremental improvements

@DzikuVx DzikuVx merged commit 0a3fbae into iNavFlight:master Apr 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants