Replacing rest_framework_jwt with django-rest-framework-simplejwt #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Glad to be a contributor! :) |
|
I would love to see django-rest-framework-simplejwt being used |
|
Same here! Thanks.
|
|
Same here! Thanks. |
pauloxnet
approved these changes
Mar 17, 2020
robypomoni
approved these changes
Mar 17, 2020
iMerica
requested changes
Mar 18, 2020
pauloxnet
approved these changes
Mar 20, 2020
|
I've pushed a complete implementation for cookies with some additional unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the fork of django-rest-auth by @ankurpandeyvns.
This seems worth doing because rest_framework_jwt is no longer being maintained and it looks like drf-simple-jwt might end up being maintained by Jazzband jazzband/djangorestframework-simplejwt#207
it seems to pass the current range of tests already implemented by dj-rest-auth as pretty much a drop-in for rest_framework_jwt