Fix potential indexing issue and remove CentOS7 from CI workflows (#47)

* Remove no longer supported CentOS7 from Key4hep workflows * Fix potential index swap
iLCSoft · Aug 26, 2024 · e473dcf · e473dcf
1 parent 881c266
commit e473dcf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/key4hep.yml b/.github/workflows/key4hep.yml
@@ -7,7 +7,7 @@ jobs:
     strategy:
       matrix:
         build_type: ["release", "nightly"]
-        image: ["alma9", "ubuntu22", "centos7"]
+        image: ["alma9", "ubuntu22"]
       fail-fast: false
 
     steps:

diff --git a/source/src/WeightedPoints3D.cc b/source/src/WeightedPoints3D.cc
@@ -885,8 +885,8 @@ void WeightedPoints3D::propagateVecErrorsCartesian(){
     Dmat[1][1] =  sin(phi)*cos(theta) ;
     Dmat[2][1] =  -sin(theta) ;
     double thph_dmat [2][3];
-    for ( int i =0 ; i < 3 ; i++ ) {
-      for ( int j=0 ; j < 2 ; j++ ) {
+    for ( int i =0 ; i < 2 ; i++ ) {
+      for ( int j=0 ; j < 3 ; j++ ) {
         thph_dmat [i][j] = 0. ;
         for (int k=0 ; k < 2 ; k++ ) {
           thph_dmat [i][j] += _theta_phi_cov[i][k][l]*Dmat[j][k];